Skip to content

refactor: simplify lexicon category handling and update data paths#156

Merged
jirhiker merged 3 commits into
stagingfrom
jir-lexicon-simplify
Sep 29, 2025
Merged

refactor: simplify lexicon category handling and update data paths#156
jirhiker merged 3 commits into
stagingfrom
jir-lexicon-simplify

Conversation

@jirhiker

@jirhiker jirhiker commented Sep 29, 2025

Copy link
Copy Markdown
Member

Why

This PR addresses the following problem / context:

  • The lexicon.json file needs to be normalized and lexicon upload needs to be simplified

How

Implementation summary - the following was changed / added / removed:

  • added add_lexicon_category
  • updated add_lexicon_term
  • updated tests
  • refactored lexicon.json

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

@codecov-commenter

codecov-commenter commented Sep 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
core/initializers.py 63.63% 4 Missing ⚠️
Files with missing lines Coverage Δ
schemas/lexicon.py 100.00% <100.00%> (ø)
services/lexicon_helper.py 76.59% <100.00%> (ø)
tests/test_lexicon.py 81.05% <100.00%> (ø)
core/initializers.py 67.64% <63.63%> (ø)

@jirhiker jirhiker merged commit 490db9a into staging Sep 29, 2025
3 checks passed
@jirhiker jirhiker deleted the jir-lexicon-simplify branch December 3, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants